brianc/node-postgres — pull request #386 by brianc (2013-06-30 18:00:18+00:00)
Title: Fix long-standing hanging SSL connection but with JavaScript

Removing event emitters on the stream before upgrading to a TLS connection prevented anything from happening after that point. The connection just "hung" forever. This would prevent anyone from being able to connect to Heroku Postgres from outside of the Heroku cloud using the pure JavaScript bindings because Heroku requires SSL connections for external clients.

This was one of the few pieces of code I merged in a long time ago without having a proper integration test for it. Shame on me for that! :no_good: I've written a test to make sure it doesn't happen again. The test uses a free instance of Heroku Postgres to make sure everything works properly.