symfony/symfony — pull request #8386 by jakzal (2013-06-30 18:35:30+00:00)
Title: [Console] Avoided an unnecessary check if a stream is an interactive terminal

| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -

It only makes sense to do the second check, if the first one evaluates to false (so the `--no-interaction` option was not passed).

Running `posix_isatty()` raises a warning with some stream types (like in-memory stream). With this patch, warning could be avoided by passing the `--no-interaction option` (which is what we want with an in-memory stream).