wesolows/node-snmpjs — pull request #13 by jbreeden (2013-06-29 17:19:46+00:00)
Title: Patching PDU creation for SNMPv1 Traps

During encoding, the op field of the pdu arg was being compared against the undefined value "SnmpPdu.Trap." This precluded the creation of SnmpTrapV1PDU items and correct encoding of v1 specific trap fields. The comparison is now against the [deprecated] "OPS.Trap" field.

Also, the enterprise field of the SnmpTrapV1PDU had a self-recursive setter. That is, the setter for pdu['enterprise'] ended with an assignment to pdu['enterprise']. This has been changed to assign to '_enterprise', as returned by the getter.

(As an aside... this is my first use of Git, Github, and of course the pull request feature. Let me know if I've done something out of the ordinary.)