dCache/dcache — pull request #108 by alrossi (2013-06-24 17:43:33+00:00)
Title: (2.6) dcache-webadmin (alarms): provide option for absence of alarms dat...

...abase

module: dcache-webadmin, dcache (alarms)

The ticket reported an SQL stack trace error in the httpd log under the condition that they (a) are not running an alarmserver, and (b) have left the default settings for alarms alone.

The immediate fix was for them to set alarms.store.db.type=xml, but it makes sense for there to be an "off" option on this property as well.

This patch adds this option and makes it the default. This complements the change of the remote log level default to off as well.

Testing done:

The following configurations were checked:

1. type = off, alarmserver started
(a) alarmserver reports: 21 Jun 2013 09:29:53 (alarms) [] alarms database type is OFF; server will not be started
(b) httpd reports: nothing
(c) page: The datastore for alarms and warnings has been disabled (see the configuration alarm properties).

2. type = xml, no store.xml, alarmserver not started
(b) httpd reports: nothing
(c) page: The datastore for alarms and warnings has been disabled (see the configuration alarm properties).

3. type = xml, alarmserver started
everything is sane

4. type = xml, with store.xml, alarmserver not started
(b) httpd reports: nothing
(c) page: query returns only what is currently in db.

5. type = rdbms, no alarms db; alarmserver not started
(b) httpd reports the underlying DataNucleus stack traces for "alarms database does not exist"
(c) page: reports Internal error
I would argue this is the correct behavior. It is a misconfiguration.

6. type = rdbms, no alarms db; alarmserver started
(a) alarmserver reports Failed to create bean 'liquibase' : FATAL: database "alarms" does not exist from ac_create_$_2_3
stops and tries to restart
(b)/(c) same as above
Again, this is correct behavior.

7. type = rdbms, alarmserver not started
(b) httpd reports: nothing
(c) page: query returns only what is currently in db.

8. type = rdbms, alarmserver started
everything is sane

Target: master
Patch: http://rb.dcache.org/r/5668
Ticket: http://rt.dcache.org/Ticket/Display.html?id=7887
Request: 2.6
Require-notes: yes
Require-book: yes
Acked-by: Gerd

RELEASE NOTES:
BOOK:

The options for alarms.store.db.type are not off,xml,rdbms, with off being the default. If no alarms service is desired, the off option will prevent the web page from trying to establish a connection the the database.