skiadas/HealCalc3 — pull request #36 by hugin7 (2013-06-23 16:22:10+00:00)
Title: Update spell.js

1. Accounted for Patch 5.3 Glyph of Smite change: Glyph of Smite no longer causes the additional 20% damage dealt by Smite to transfer into Atonement.

2. Updated for Patch 5.3 Atonement nerfs: Atonement now heals nearby friendly targets for 90% of the damage dealt, down from 100%.

3. Fixed Atonement average heal calculation. There does not appear to be any triple-dipping into the crit effect meta. The combined critical heal from Atonement is base heal + base heal * mastery % from character screen. A key revelation is that the crit meta gem is completely ignored for Atonement! The updated calculation was tested against combat logs and appears accurate.

I verified the updated calculations by approaching a target dummy and smiting away, clearing any Evangelism/trinket/Jade Spirit etc. effects after every cast. I only had Holy Fire active (no food or raid buffs). For example, if a Smite crit healed me for 16021 (Atonement heals the caster for 50%), it would pop a Divine Aegis for 19463. My mastery percentage from the character screen is 21.49%, and 16021 * 1.2149 = 19463.9, which is very close to the result from my combat logs. I suspect that Blizzard's approach to rounding might account for the minor difference.

My crit percentage from the character screen is 19.28%, respectively, yielding a calculation of
16021*((1-0.1928)+(1+(1.2149))*0.1928) = 19773.64241 for the average heal.

4. Accommodated Penance changes for Patch 5.3: Penance now deals 10% less damage, but healing done is increased by 10%.