skn3/monkeyspine — pull request #10 by ziggybcn (2013-06-11 14:56:24+00:00)
Title: Several (a lot) of small fixes and detection of areas that require fixing.

I've made lots of fixes. As I do not have a deep knowledge of the
module, it is highly advisable if anyone (Skn3?) Could take a deeper
lool to my fixes.
I've marked them all with a Jungle Ide note, so they're ultra easy to
locate in a glance.
all marked with 'note: Ziggy: are fix suggestions that should allow the
module to compile.
Then, there are much more crytical fixes marked with 'note: FIX TODO
that require some thought, as they seems like a design logical bugs,
such as Void methods that have Return statements with actual return
values!! or the like. Also, the creation of an abstract Map with a New
keyword, etc.
It requires additional attention by someone that has deeper knowledge on
this module internals.
Hope it's helpful!

EDIT: I've seen some changes (as instance a Map replaced by a FloatMap) that I havent done, but are marked in the changes list, so I suppose it will require some change-by-change check. Maybe I'm rolling back some change made by you, but I honestly thing the amount of fixes deserves some attention, as I think this module can be really worth it!

I hope all this is constructive and well received, thanks for the awesome work done!