openexr/openexr — pull request #65 by fnordware (2013-06-07 22:51:23+00:00)
Title: Windows crash from out-of-range vector access

I was getting a crash in Windows from this line. Near the end of this loop offset == overall_sample_count, and that's the problem.

Windows doesn't like it if you try to access the address of an element outside
the range of the vector size. So if the size is n, &vec[n] will crash
(the last element is vec[n-1]). This also applies to &vec[0]
on an empty vector.

GCC is OK with it and I think returns NULL, but in Windows it will crash (at
least with Visual Studio 2008). Is there a C++ spec that says the vector should return NULL in this case? Otherwise doesn't seem like a kosher thing to do.