discourse/discourse — pull request #970 by chrishunt (2013-06-06 04:59:49+00:00)
Title: You already like me

This pull request improves the on-boarding experience for new users when 'must approve users' is enabled.

As outlined in [meta/4580/22](http://meta.discourse.org/t/can-discourse-be-configured-to-always-require-login/4580/22):

1. User creates new account
1. Message is display: [`b851bb8b`](https://github.com/chrishunt/discourse/commit/b851bb8bed18e56b15daf91a30d67e18f646f9b7)
- "Thanks for signing up. We will notify you when your account has been approved."
- *No email is sent*
1. Admin approves new account
1. Message is display to the admin [`896b8f58`](https://github.com/chrishunt/discourse/commit/896b8f58d892380d0e57a0a9fbed241d1d044de6)
- "Approved, email sent ..... etc"
1. User receives email [`2d8cdfd4`](https://github.com/chrishunt/discourse/commit/2d8cdfd47a0d7e9ee49f3e72f02ea0f12f07f583)
- "Welcome!! Awesome!! Click this link to activate your account"

As for the edge cases:

1. User creates account and tries to login before being approved:
- A message is display [`c985d89f`](https://github.com/chrishunt/discourse/commit/c985d89fe9727956a5ee959dd100f914726d778b)
- "Your account hasn't been approved yet. You will be notified by email when you are ready to log in."

1. User receives approval email, but never clicks the link to activate account. Then that user tries to login.
- A message is displayed [`c985d89f`](https://github.com/chrishunt/discourse/commit/c985d89fe9727956a5ee959dd100f914726d778b)
- "You can't log in yet. We previously sent an activation email to you at user@example.com. Please follow the instructions in that email to activate your account. Click here to send the activation email again."