Bertram25/ValyriaTear — pull request #182 by logzero (2013-06-04 19:22:36+00:00)
Title: Fix unsafe erase.

Another cppcheck hit.

Btw:
I've noticed quite a few vector erase loops. There is an optimization possible, called "swap and pop". It can be applied if the order of items doesn't matter. Of course it only matters if the vectors have got some decent size ( >4 or so ;) ).

Instead of:
for (;it != foo.end();) {
if (...)
it = foo.erase(it);
else
++it;
}

you can write:
for (;it != foo.end(); ++it) {
if (...) {
*it = foo.back();
foo.pop_back();
}
}