sgentle/phantomjs-node — pull request #83 by scien (2013-05-31 05:07:11+00:00)
Title: Reopen Fix passing command line arguments to "create"

https://github.com/sgentle/phantomjs-node/pull/82

- fix bug in previous merge
- add express to devDependencies
- clean up tests
- consistent naming with ph
- using @callback instead of test.callback
- naming parameters instead of _, _1, _2
- add test for create with arguments, but seems like we'd need to give phantom more info to test this fully. or arguments aren't passing through the shim correctly because get "args" returns just [port] instead of ["--load-images=yes", port]. phantomjs is also deprecating this and telling us to use system.args, which would mean exposing this data elsewhere.
- create phantom's on different ports for each test file so "cake test" works
- fix API reference link

I commented out the onAlert and onConsoleMessage tests. They are crashing for me. Can someone else try them out and see if they get the same result? Do we need to update the shim to support these?

phantom stderr: PhantomJS has crashed. Please read the crash reporting guide at https://github.com/ariya/phantomjs/wiki/Crash-Reporting and file a bug report at https://github.com/ariya/phantomjs/issues/new with the crash dump file attached: /tmp/8CEC6982-871F-4606-933A-F98BF5715B07.dmp