kveeiv/extjs-boxselect — pull request #33 by themightychris (2013-05-28 01:51:50+00:00)
Title: fixed call to createFilterFn in onTypeAhead

This is strange, under 4.2 I encountered an error in onTypeAhead's attempt to call this.createFilterFn which was undefined.

I cannot in the history of ExtJS 4.x find a version where ComboBox has a createFilterFn method, judging by the parameters the intended method is Store.createFilterFn.

This error doesn't surface on the demo page because it runs 4.1.1, which oddly makes no use of an onTypeAhead method in ComboBox or its parents -- the override containing the error never gets called, making me wonder if it is even necessary? onTypeAhead exists in 4.1.3+ though

Store.createFilterFn returns false if the value string is blank, necessitating an extra check

I'm not sure if this onTypeAhead override is still needed, but this patch seems to fix it under versions of ExtJS that implement ComboBox.onTypeAhead