yui/yui3 — pull request #781 by sdesai (2013-05-24 19:47:55+00:00)
Title: Change Base/BaseCore to add all ATTRS up the hierarchy in one addAttrs() call.

This pull request changes Base/BaseCore to add all ATTRS up the class hierarchy in one shot, as opposed to adding them one class at a time.

See: https://github.com/yui/yui3/issues/629 for more details about the edge-case issue it is trying to fix.

It also takes care of the resulting cleanup:

1. Updates Widget's HTML_PARSER to account for the change in attribute adding behavior (https://github.com/sdesai/yui3/commit/002a4aa5b39c01bd1021fd0830e54fabd645f8fa). NOTE: This is expected to be a really rare edge case.
2. Removes the short term workaround added just before 3.10.0 for CandleStickSeries (https://github.com/sdesai/yui3/commit/ebaa6b69820803f52890c99044d76f2cf3541228).
3. Fixes out-of-order attribute set references when adding multiple attributes at once (https://github.com/sdesai/yui3/commit/ebaa6b69820803f52890c99044d76f2cf3541228).

### Testing

**All** library tests pass:
✔ [Total]: Passed: 10899 Failed: 0 Total: 10996 (ignored 97)

* Tests have been added for the order of operation scenarios at the Base level.
* Tests exist already for Widget HTML_PARSER

### BackCompat and Preview Release Adoption

This change has a subtle back-compat issue, outlined in the issue report above (Widget HTML_PARSER is an example), which hopefully is pretty rare, and can be worked around.

However as a result, the goal is to get a preview release for this, and https://github.com/yui/yui3/issues/702 out early in the next sprint cycle so that we can try and see if this is a real-world issue which would prevent us from proceeding with the fix. I'd rather not have more code/switches added to support "old behavior on/off" in there, if it's not a real-world issue.

The pull request is for dev-3.x, and doesn't need to be merged before the current sprint freeze, but would like to get people looking at it/providing feedback so we're ready to PR it early in the next sprint to give us time to react to issues.