burtbeckwith/grails-ui-performance — pull request #1 by kaaloo (2013-05-23 16:48:58+00:00)
Title: Our customizations

Hi Burt!

I hope you are having a good time at the gr8conf! Are you coming through Paris by any chance ?

In any case following our move to github for most of our projects at Balsamiq, I have created an updated fork from your master with our "enhancements". You may not like all the changes and I'm sorry, I was for a day or two unable to debug using run-war so I had to test on our staging system.

I'm not that familiar with git but if you can send me some pointers I can try to create a rebased branch with a single commit for you to look at.

One of the important changes is making sure the CacheFilter mapping comes before the CompressingFilter mapping in the web.xml, otherwise it just doesn't work. There is also handling of the obscure accept encoding request header with a value of gzip;q=0 which means I can't handle gzip encoding. I have also added handling of .swf files.

One of the things I dropped in one of the improvements is handling "quoted=false" when generating links. We don't have any use for it but you may want to keep that in the plugin.

Finally, I fixed the issue with double slashes when generating links (I think, at least all tests pass now).

Let me know if you want to discuss anything or have me issue a "cleaner" pull request.

Luis