Metaswitch/sprout — pull request #28 by kswmsw (2013-05-22 09:13:50+00:00)
Title: [Reviewer: Mike] Valgrind fixes

Hi Mike - please could you review? The first commit is just a bizarre merge screwup, where my valgrind-disabling code ended up in the wrong test entirely! The second is more interesting, and warrants a discussion - I was seeing a leaked UASTransaction on an INVITE that had received a 200. The tsx was going to Terminated but not to Destroyed until the test wrapper stopped the tsx layer entirely - and destroying it that way doesn't invoke the callback which deletes the UASTransaction object. From the suppression file it looks like we've previously seen this with UACTransactions as well, and we've put in a fairly general rule. I'm a bit sad about that - if we disable VG's leak-checking, how will we spot leaks? Do you have any suggestions as to how to proceed?

I'm going to merge this now, since you're in a different timezone.

Thanks.

--KW 8-)