agapered/looky-lu — pull request #1 by joeletizia (2013-05-16 18:44:59+00:00)
Title: Oh Canada - Integrating our neighbors to the North

So I saw this project posted on Reddit and I was bored since I'm between jobs. Figured I could get some open source fun going.

### What I Did

In the `States` class, I created additional methods. `States.all` will return an array containing both Canadian provinces, and US states. `States.united_states` remains the same, and `States.canada` returns only the 10 canadian provinces. `States.from_country` takes a string parameter that will allow the user to select what set they want returned. The default blank parameter returns data for the US.

In the `StateDataGenerator` class, I added an argument for the country name (`country_name`). This parameter is passed to the to the #from_country method. I also did some indentation on the private methods.

I added an extra spec for the `LookyLu::States` class, although the expectations are pretty redundant.

In the `StateDataGenerator` spec, I added a context for each call/country. These specs aren't very DRY, do you have any input on them?

I also factored some non-DRY code int eh spec helper.

Hope this helps/you can give me some pointers!

Thanks.