brianchandotcom/liferay-portal — pull request #11086 by mdelapenya (2013-05-16 14:08:46+00:00)
Title: Lps 33946 mdr rules

Brian, I'm resending this PR (you already reviewed): https://github.com/brianchandotcom/liferay-portal/pull/10634

These are my changes:

1.) Let's get rid of the SQL caching, I think it's not necessary and makes it hard to read. I only add them in after the fact if performance tests show they actually make a difference.

I've cached the SQL because a user could want to retrieve rules including or not glabal scoped rules: sometimes the query will include global groupId, sometimes not.

2.) But if you were to add them, they ought to follow the format in GroupFinderImpl (String findByX_Y_SQL, not jsut String findByX_Y).

Done, variables have been renamed following the pattern

3.) The test is in the wrong package.

Done, I missed package name and now tests are in *.service package.