alphagov/trade-tariff-backend — pull request #82 by sauliusg (2013-05-15 11:17:24+00:00)
Title: Disable conformance validations for Mfmc update

This is meant to solve CHIEF update application problem that appeared today (15th of May 2013). I.e.:

```
Operation:

#2013-05-14 14:14:00 +0000, :msrgp_code=>"VT", :msr_type=>"S", :tty_code=>"B00", :le_tsmp=>2013-05-14 14:28:00 +0000, :audit_tsmp=>2013-05-14 14:13:00 +0000, :cmdty_code=>"5607509090", :cmdty_msr_xhdg=>"N", :null_tri_rqd=>"N", :exports_use_ind=>false, :tar_msr_no=>nil, :processed=>false, :amend_indicator=>"U", :origin=>"2013-05-15_KBT009(13135).txt"}>
Model:

#-41534, :measure_type=>"VTS", :geographical_area=>"1011", :goods_nomenclature_item_id=>"5607509090", :validity_start_date=>2007-10-01 00:00:00 +0000, :validity_end_date=>2013-05-14 14:28:00 +0000, :measure_generating_regulation_role=>1, :measure_generating_regulation_id=>"IYY99990", :justification_regulation_role=>nil, :justification_regulation_id=>nil, :stopped_flag=>false, :geographical_area_sid=>400, :goods_nomenclature_sid=>70762, :ordernumber=>nil, :additional_code_type=>nil, :additional_code=>nil, :additional_code_sid=>nil, :reduction_indicator=>nil, :export_refund_nomenclature_sid=>nil, :created_at=>2012-12-12 12:00:07 +0000, :updated_at=>nil, :national=>true, :tariff_measure_number=>nil, :invalidated_by=>nil, :invalidated_at=>nil}>

Errors:

{:goods_nomenclature=>["Commodity does not span validity date of Measure"]}

Exception

goods_nomenclature Commodity does not span validity date of Measure
```

I think we should not be performing conformance validations on national data at all. It is just not meant to be validated. This is one of those times when Taric and CHIEF data collides. This is the first change that goes in this direction, we may need to review ChiefTransformer and do more testing.

We had a case when Taric adds validity end date to Commodity and makes associated national measures invalid. This time CHIEF tries to extend Measure validity period on a national measure and this period spans beyond associated Goods code validity period and this breaks conformance validation. I think it's evident that neither CHIEF maintainers pay much attention to what's happening in Taric and how that impacts CHIEF records nor of course the other way around. So I think we should just not force the impossible to happen. Extension of measure validity period should not have much impact anyway, because we won't show Goods code after it's validity period end. Any thoughts about all this?