Metaswitch/pjsip-upstream — pull request #2 by mirw (2013-05-10 15:46:36+00:00)
Title: [Reviewer: Mike] Correct handling of exceptional events

Mike, I've found an issue with the fix to bug128 - we were checking a condition that couldn't possibly be true (!(events[i].events & EPOLLERR)) because the containing block was only entered if the opposite was true. The condition should read (!(events[i].events & EPOLLIN)) but this is now superfluous because if that condition were true we would have entered a previous branch and then done a "continue" to skip over the rest of the block. As a result, I've simply removed this check. I've tested this while running stress and not seen the same ioqueue hangs that I saw before.