endroid/QrCode — pull request #8 by edorfaus (2013-05-06 14:36:46+00:00)
Title: Remove URL-decoding of the data string, and a pair of unused variables.

Automatically URL-decoding the text content probably made sense when it was fetched from the query parameters, but since the text is now set from code, I think it is the responsibility of the calling code to do this if it is necessary. Especially since it isn't documented on the setText() method that the text will be decoded when generating the code.

This commit also removes a pair of unused variables I found in the same area. (Well, one was technically used once, but not for anything useful as far as I could tell.)

While I'm at it, I have a question: would you accept pull requests that only do things like clean up the indenting or other code style bits? At the moment the class has a mix of styles, which makes me feel like cleaning it up to be more consistent...

If yes, do you have any particular preferences for styles that I should adhere to?