puppetlabs/puppet — pull request #1629 by jeffmccune (2013-05-02 01:21:17+00:00)
Title: (maint) Fix various acceptance failures on Fedora Core 18 (maint) Remove acceptance test for puppet --parseonly deprecation

Without this patch the acceptance test for the puppet master --parseonly
and puppet agent --parseonly is failing. This is a problem because in
Puppet 3 the deprecation has been removed and instead Puppet reports an
error that the command line is incorrect, 1 argument was provided
instead of the expected 0 number of arguments.

This patch addresses the problem by changing the acceptance test to no
longer validate the presence of the deprecation warning and instead
validate the expected behavior of `puppet parser validate`.

(maint) Add Fedora Core suitability check for password redaction

Without this patch the Fedora Core 18 system, prefixed by `fc-` is
assumed to be able to manage password. This is a problem because the
system does not have the shadow gem installed by default.

This patch adds `fc-` to the list of platforms checked for suitability
before running the acceptance test.
(maint) Fix uninitialized constant ActiveRecord

Without this patch the Puppet master is reporting error 400 in the
acceptance test suite running against Fedora 18, with the error message
`Could not autoload puppet/indirector/catalog/active_record:
uninitialized constant ActiveRecord`. This is causing the
`enc_provides_node_when_storeconfigs_enabled.rb` acceptance test to
fail.

The root cause of the problem is attempting to access the ActiveRecord
constant before loading the library. This patch addresses the problem
by making sure the `activerecord` library is loaded prior to accessing
the constant.

References: https://projects.puppetlabs.com/issues/16670

(maint) Remove pending parser validate test

This test is failing on my Fedora 18 system under test and it has a
"real" copy outside of the pending/ directory.