nmonkee/metasploit-framework — pull request #5 by jvazquez-r7 (2013-05-02 03:01:19+00:00)
Title: Cleanup for sap_soap_rfc_rzl_read_dir_local_dir_listing_and_smb_relay

Hi @nmonkee,

In this pull request I'm trying to cleanup sap_soap_rfc_rzl_read_dir_local_dir_listing_and_smb_relay.rb. Please feel free to review, discuss, test, etc any of the changes proposed. Once you feel comfortable just land this pull request in your repository and the original one: https://github.com/rapid7/metasploit-framework/pull/1657/files will be automatically updated. And we'll be ready to merge it.

Summary of Changes:

* Keep modules filenames shorter.
* Run tools/msftidy.rb, modules must be compliant.
* Use the guidelines proposed on https://github.com/rapid7/metasploit-framework/wiki/How-to-Send-an-HTTP-Request-Using-HTTPClient when using HTTPClient.
* Since it's an Scanner module, in order to avoid verbosity, try to use print only for the minor information possible (normally success). For the others prints use the verbose print => vprint_*
* Please add the name of the vulnerability discoverer to the Authors section when available, helps to document modules.
* Please add known references such as OSVDB, BID or CVE to the References section when available, helps to document modules.
* When there are required options always make things easier to provide a default option if possible.
* Parsing profitable information, in this case the dir enumeration from the xml response helps to present better the results. Even when storing the loot is a good thing to store the full response. Even when int his Scanner module the parsed results are only showed to the user when mode VERBOSE = true.

Thanks!