arashpayan/appirater — pull request #113 by rsanchezsaez (2013-04-30 10:18:58+00:00)
Title: Delegate variable is strong

Shouldn't

static id _delegate;

be

__weak static id _delegate;

instead?

Usually, all delegates are weak to avoid retain cycles in delegates of non-singleton objects. This shouldn't be as much of a problem with a Appirater, which only has class methods (similar to a singleton) but still I think it's best practice to declare the delegate as `__weak`.