puppetlabs/puppet — pull request #1624 by jeffmccune (2013-05-01 00:41:00+00:00)
Title: Fix various acceptance test failures on MRI 1.9.3 (maint) Fix enc_provides_node_when_storeconfigs_enabled on precise

Without this patch the enc_provides_node_when_storeconfigs_enabled is
failing on Ubuntu 12.04 LTS with MRI 1.9.3-p0. The root cause of the
failure is that the ENC script used does not output valid YAML data, it's
lacking the `--- ` header.

This patch addresses the problem by using `Hash#to_yaml` to produce valid
YAML output for the ENC API.

(#7224) Fix hostname does not match on Ubuntu 12.04

Without this patch Puppet does not improve upon the `hostname does not
match the server certificate` error message coming from OpenSSL. The root
cause of this problem is a bad regular expression that matches on
`error.message =~ /hostname (was )?not match/` when the error message on
precise is actually `"hostname does not match the server certificate"`

This patch addresses the problem by allowing any word to optionally exist
between `hostname` and `not` in the error message.

(maint) Fix install module acceptance test on precise

Without this patch the `with_modulepath.rb` acceptance test is failing on
Ubuntu 12.04. The cause of this problem is that `puppet apply` is being
used to purge the `/etc/puppet/modules2` directory, which doesn't appear to
be working as expected. This itself is concerning, but the concern is
unrelated to the expected behavior expressed in the test.

This patch addresses the problem by simply using `rm -rf` to purge the
acceptance test instead of using `puppet apply`.