pfsense/pfsense-packages — pull request #434 by bmeeks8 (2013-04-27 02:03:33+00:00)
Title: Snort Package 2.5.7 -- Two minor bug fixes (no need to bump version)

Snort 2.9.4.1 Package Version 2.5.7
===============================
CHANGE LOG -- 04/26/2013
===============================
This is a minor update to fix two small bugs in the 2.5.7 package and it also reverts a log message text change at the suggestion of Ermal. The changes listed here are minor enough that a package version update should not be necessary.

Bug Fixes
===================
1. The HTML textarea control used in the pop-up window for creating/editing custom rules and for viewing text rules was using a deprecated value for the "wrap" property. It was using "on" to specify wrapping of text instead of the new standad value of "soft". This worked fine in Internet Explorer and Firefox, but caused problems with the soft-break characters getting included in the returned text string posted to the HTML form on Google Chrome. This resulted in a munged custom text rule that Snort would barf on (because of the included soft-break characters). Changing the property to "wrap=soft" corrects the issue and it works correctly now on IE, Firefox and Chrome browsers.

2. Found one more instance in the "snort_check_for_rule_updates.php" module used for automated rules update where a string variable used within a longer quoted string was not delimited by {}. Hopefully this is the last one of these! I looked the file over about a dozen times this time trying to be 100% sure. There was also one spot where an exec() call was made to create a directory where the arguments were in single quotes instead of double quotes. The single-quote version works correctly when run from within the GUI, but would fail and create its directory in the wrong place when called from the cron process. Must be a GUI versus CLI environment thing with PHP. Adding double-quotes like all the other exec() calls fixed the problem.

Reverts
====================
At Ermal's suggestion, the text printed for the system log messages associated with Snort and Barnyard2 start/stop operations from the Snort Interfaces tab was changed back to be the Interface Name from pfSense accompanied by the Snort Interface Description entered by the user. This is a log message content change only.