puppetlabs/puppet — pull request #1621 by jeffmccune (2013-04-26 22:37:45+00:00)
Title: (#20302) Fix failing acceptance test for windows providers

Without this patch the windows acceptance test
ticket_6907_use_provider_in_same_run_it_becomes_suitable is failing on
windows because the behavior that determines of a file is a command or
not, and thus if the provider is suitable or not behaves differently on
Windows than it does on *nix. This difference in behavior is caused by
Windows determining execute ability by inspecting the PATHEXT
environment variable, and a file with no extension will not be
considered executable.

This problem will not be observed in MRI 1.8.7 because File.executable?
always returns true for any file that exists. The problem will be
observed in MRI 1.9.3 because this behavior changed in
http://bugs.ruby-lang.org/issues/show/2135

This patch addresses the problem by changing the file to have an exe
extension. This makes the test agnostic to the underlying behavior of
windows or Unix.