KocsisDaniel/liferay-portal — pull request #269 by victormirandabeltran (2013-04-23 11:11:30+00:00)
Title: LPS-33680

Hey Daniel.

I reviewed your changes and did some modifications:

The biggest one, was change the updateLink method because the previous code removes the reverse link weight.

e.g.:
Link from google to wikip with weight 2
Link from wikip to google with weight 1

reading google in the importer
created assetLink google -> wikip (weight 2)
created assetlink wikip -> google (weight 0)

reading wikip in the importer
detected link wikip -> google, updating it.
removed link wikip -> google;
removed link google -> wikip.
created link wikip -> google (weight 1)
created link google -> wikip (weight 0) !!!!

I also changed some exception handling (getLink method could return NoSuchLinkException), and the getAssetLinkPath method in order to follow the common pattern in the PortletExporter.

Finally, reviewing our conversation, I remembered that you tell me that this kind of code makes no sense:
assetCategory.setUserUuid(assetCategory.getUserUuid());

As I told you yesterday, I was copied it from the exportAssetCategory. Obviously, this is a mistake, but I think that in the exportAssetCategory method it has to be changed too in another LPS.

Thanks for your time,

Victor Mirnada