quandl/Python — pull request #6 by ihodes (2013-04-18 22:21:11+00:00)
Title: Follow PEPs 8 and 257, and some code-tidying/fixes

# Changes in this PR

I made some changes which may not be loved; I'll outline those here for review:

There is a breaking change in this PR, as startdate and enddate are now
called trim_start and trim_end: I renamed these in the code to reflect this.

I also removed much of the explicit type-checking (in the name of ducktyping).
Additionally, I removed the checked for allowable param values, as those are
documented and explicitely checking them only adds overheads and, if at some
point Quandl allows other options, would require changes to this library to
implement.

---

# Future Possibilities

I'd also like to completely remove all explicit params in the `get` method,
as they may change as Quandl's API does (c.f. startdate and enddate). Instead,
would it make sense to use `**kwargs`, and interpolate those keyvals as they're
passed?

I don't have a lot of experience with writing API libraries, so maybe I've messed
with some best-practices; please let me know!