maplesyrup/maple-android — pull request #136 by benrudolph (2013-04-17 03:26:58+00:00)
Title: Introduces topbar

@elihart, @rpandey1234

This is a FAT pull request, but really important because it introduces a couple of new conventions that we should stick to.

First of all, this PR merges Rahul's changes (I fixed the conflicts) so we shouldn't need to merge that PR. The biggest change about this is the new FunnelActivity. I moved a ton of code to that class. Since we can access protected variables, we need only declare mAppmConfig variable which holds various config settings. I used this to set the title and help message of each activity:

https://github.com/benrudolph/maple-android/pull/new/topbar#L23R38

We should now have a lot less repeated code. If we have a button that does the same action we can just put it in the FunnelActivity. If it doesn't seem to fit into the superclass then perhaps the Utility is the place for it. Either way I'm excited about not having to copy and paste my code into 7 files.