ronin-ruby/ronin-asm — pull request #11 by TheNotary (2013-04-16 23:00:50+00:00)
Title: Fixed intel syntax order

Hey, here's an improved pull request. I don't know what happened with the old one but apparently my integration tests stopped passing at some point and I didn't realize it. It was uber weird but w/e.

About your wanting to remove the :att syntax feature all together, that's definately one way to go about it, but if you've made a release and people are relying on your code and you're removing a feature, you might want to treat it as a proper deprecation and give them a chance to migrate to the :intel syntax or if they really just want their code to work again, they can key in the syntax: :att line when they instantiate their asm code blocks.

If you wanna cherry pick this that's fine too, I found a bug regarding automatic exclusion of :yasm tests, it's now excluding :integration tests as that they've been renamed. I left in my Rakefiles for running current files and using pry, it's kind of a pain removing and adding them back in. You might wanna consider making it possible to do a `rake spec:all` which seems to be imposible right now due to the way you're excluding integration tests from within spec_helper rather than in the Rakefile. I really just wanna get to implementing compiling complete ASM binaries so I can move on ha, so let me know what you think.