dougrathbone/Ga.net — pull request #5 by NullSoldier (2013-04-13 02:45:10+00:00)
Title: Fixed critical issues

I wanted to use your library but when I pulled your code down it didn't even compile. On top of that, reporting page views didn't work at all. I also noticed you removed events from your example so I re-added it back in.

Another major change is that I've removed the dependency of the app.config file. If you use TrackMe, it will still look in your app.config file for the account code; but otherwise if you invoke the library directly (which is what I wanted) then you can now specify the Google account code.

Critical fixes:
- Page view requests were not sent correctly causing them to never be reported
- The project did not compile because of the sample

Improvements:
- Removed dependency on app.config file
- Added derived files to .gitignore so they won't be added to the repository
- Removed lots of unused code, there's no reason for it. You can get it from your GIT history if you need it again
- Since the data objects (GooglePageView and GoogleEvent) are immutable (and should be), there's no need for validation functions. I moved validation to the constructor.
- Lots of XML comments referenced non-existent parameters. I removed them

In short, I fixed lots of things. The example now works, the code now works. I've tested it.