rapid7/metasploit-framework — pull request #1730 by h0ng10 (2013-04-12 19:55:39+00:00)
Title: Add verbose check to msftidy.rb

This pull requests adds a check for manual VERBOSE Options to msftidy.rb.
According to the wiki page [Common Metasploit Module Coding Mistakes](https://github.com/rapid7/metasploit-framework/wiki/Common-Metasploit-Module-Coding-Mistakes) this should be avoided.

I tested the commit with the following Strings, which all are detected:
```
OptString.new('VERBOSE',[ false, 'XXXXX', false ])
OptBool.new('VERBOSE',[ false, 'XXXXX', false ])
OptBool.new('VERBOSE',[false, 'XXXXX', false ])
OptBool.new("VERBOSE",[ false, 'XXXXX', false ])
OptBool.new( 'VERBOSE' , [ false, 'XXXXX', false ])
OptBool.new( "VERBOSE" , [ true, 'XXXXX', false ])
```
Output:
```
./msftidy.rb ../../../verbose_test.rb
verbose_test.rb - [WARNING] VERBOSE Option is already part of advanced settings, no need to add it manually.
```
If you have any questions, please let me know.