nevir/groc — pull request #80 by michaelparenteau (2013-04-10 07:50:51+00:00)
Title: Should the nav behavior really work this way?

Hey there, Let me start by saying that I think this project is awesome.

This pull request is not a solution... it is just a conversation starter. I was poking around on the site and noticed that the behavior of expanding the nav is reliant on the user clicking the arrow icon. I didn't discover this right off the bat. I clicked the
a number of times and saw that it added the class of "selected"... but this was confusing as the content in the view didn't change.... just the background style highlighted. So it got me thinking... maybe I should click the arrow icon. And then it expanded the list. This seems broken to me. I feel like all items in the list should have some behavior that will have some actionable change in the view. For example... if there is no item in the list.. then change the main content view. If there is a base page, or default view associated with the list item with an arrow icon, it should change the content in the main view and also expand the list... if there is no default content for the list item with the arrow icon... then it should at least "expand" the list to show the sub nav contents, no?

I humbly send this pull request to ask if any thought has gone into this and if there is a reason that the behavior of the nav doesn't work this way already. I would have sketched out an implementation of the working code if I could fully "groc" all the code involved in this... but then I figured I would get this comment out instead as I am sure that there are folks who know this codebase way better than I do and they would have opinions on how this should really work and also how you guys want to do things here.

Thanks... if you want to connect to talk about this further.. please ping me.

:bike: :bike: :bike: :+1: