ansible/ansible — pull request #2636 by tima (2013-04-10 16:47:36+00:00)
Title: Commit 290780d changed the return value and broke a unit test in TestPlayBook.py.

I use a Jenkins instance at the office to monitor Ansible. Last night a commit caused a unit test to start failing. Based on my understanding of the new logic, Ive updated the expected value to coincide.

---

Regression

TestPlayBook.TestPlaybook.test_includes (from nosetests)

Error Message

-------------------- >> begin captured stdout << ---------------------
['start', ['play start', ['all']], ['task start', [u'debug msg="foobar"', False]], ['ok', ['localhost', {'msg': u'foobar', 'invocation': {'module_name': u'debug', 'module_args': u'msg="foobar"'}}]], ['play start', ['all']], ['task start', [u'debug msg="$variable"', False]], ['ok', ['localhost', {'msg': u'$variable', 'invocation': {'module_name': u'debug', 'module_args': u'msg="$variable"'}}]], ['play start', ['all']], ['task start', [u'debug msg="foofoo"', False]], ['ok', ['localhost', {'msg': u'foofoo', 'invocation': {'module_name': u'debug', 'module_args': u'msg="foofoo"'}}]], ['play start', ['all']], ['task start', [u'debug msg="$variable"', False]], ['ok', ['localhost', {'msg': u'$variable', 'invocation': {'module_name': u'debug', 'module_args': u'msg="$variable"'}}]], ['play start', ['all']], ['task start', [u'debug msg="$item"', False]], ['ok', ['localhost', {'msg': u'$item', 'invocation': {'module_name': u'debug', 'module_args': u'msg="$item"'}}]], ['play start', ['all']], ['task start', [u'debug msg="$variable"', False]], ['ok', ['localhost', {'msg': u'$variable', 'invocation': {'module_name': u'debug', 'module_args': u'msg="$variable"'}}]]]
**ACTUAL**
{
"localhost": {
"changed": 0,
"failures": 0,
"ok": 6,
"skipped": 0,
"unreachable": 0
}
}
**EXPECTED**
{
"localhost": {
"changed": 0,
"failures": 0,
"ok": 10,
"skipped": 0,
"unreachable": 0
}
}

--------------------- >> end captured stdout << ----------------------

Stacktrace

File "/efs/dist/python/core/2.6.5/exec/lib/python2.6/unittest.py", line 279, in run
testMethod()
File "/.statelite/tmpfs/data/VCS/est-ax010-d/logs01/jenkins/workspace/ansible-devel/test/TestPlayBook.py", line 212, in test_includes
assert utils.jsonify(expected, format=True) == utils.jsonify(actual,format=True)

-------------------- >> begin captured stdout << ---------------------
['start', ['play start', ['all']], ['task start', [u'debug msg="foobar"', False]], ['ok', ['localhost', {'msg': u'foobar', 'invocation': {'module_name': u'debug', 'module_args': u'msg="foobar"'}}]], ['play start', ['all']], ['task start', [u'debug msg="$variable"', False]], ['ok', ['localhost', {'msg': u'$variable', 'invocation': {'module_name': u'debug', 'module_args': u'msg="$variable"'}}]], ['play start', ['all']], ['task start', [u'debug msg="foofoo"', False]], ['ok', ['localhost', {'msg': u'foofoo', 'invocation': {'module_name': u'debug', 'module_args': u'msg="foofoo"'}}]], ['play start', ['all']], ['task start', [u'debug msg="$variable"', False]], ['ok', ['localhost', {'msg': u'$variable', 'invocation': {'module_name': u'debug', 'module_args': u'msg="$variable"'}}]], ['play start', ['all']], ['task start', [u'debug msg="$item"', False]], ['ok', ['localhost', {'msg': u'$item', 'invocation': {'module_name': u'debug', 'module_args': u'msg="$item"'}}]], ['play start', ['all']], ['task start', [u'debug msg="$variable"', False]], ['ok', ['localhost', {'msg': u'$variable', 'invocation': {'module_name': u'debug', 'module_args': u'msg="$variable"'}}]]]
**ACTUAL**
{
"localhost": {
"changed": 0,
"failures": 0,
"ok": 6,
"skipped": 0,
"unreachable": 0
}
}
**EXPECTED**
{
"localhost": {
"changed": 0,
"failures": 0,
"ok": 10,
"skipped": 0,
"unreachable": 0
}
}

--------------------- >> end captured stdout << ----------------------

Standard Output

['start', ['play start', ['all']], ['task start', [u'debug msg="foobar"', False]], ['ok', ['localhost', {'msg': u'foobar', 'invocation': {'module_name': u'debug', 'module_args': u'msg="foobar"'}}]], ['play start', ['all']], ['task start', [u'debug msg="$variable"', False]], ['ok', ['localhost', {'msg': u'$variable', 'invocation': {'module_name': u'debug', 'module_args': u'msg="$variable"'}}]], ['play start', ['all']], ['task start', [u'debug msg="foofoo"', False]], ['ok', ['localhost', {'msg': u'foofoo', 'invocation': {'module_name': u'debug', 'module_args': u'msg="foofoo"'}}]], ['play start', ['all']], ['task start', [u'debug msg="$variable"', False]], ['ok', ['localhost', {'msg': u'$variable', 'invocation': {'module_name': u'debug', 'module_args': u'msg="$variable"'}}]], ['play start', ['all']], ['task start', [u'debug msg="$item"', False]], ['ok', ['localhost', {'msg': u'$item', 'invocation': {'module_name': u'debug', 'module_args': u'msg="$item"'}}]], ['play start', ['all']], ['task start', [u'debug msg="$variable"', False]], ['ok', ['localhost', {'msg': u'$variable', 'invocation': {'module_name': u'debug', 'module_args': u'msg="$variable"'}}]]]
**ACTUAL**
{
"localhost": {
"changed": 0,
"failures": 0,
"ok": 6,
"skipped": 0,
"unreachable": 0
}
}
**EXPECTED**
{
"localhost": {
"changed": 0,
"failures": 0,
"ok": 10,
"skipped": 0,
"unreachable": 0
}
}