sageb0t/testsage — pull request #2282 by sageb0t (2013-03-28 19:53:50+00:00)
Title: [with link to spkg, positive review] readline currently not building dynamic library on Mac

Imported from trac #2282.

Currently, readline fails to build a dynamic library on Mac, and the sage installer doesn't notice this at all. Once this happens, other things (notably Pari) can't find readline, and know not to build against the system-wide fake readline (Mac ships a pseudo-readline for licensing reasons). Pari then doesn't have readline support, and is annoying to use. Luckily, there was a fix on the [http://www.ufr-mi.u-bordeaux.fr/~belabas/pari/doc/faq.html#mac10readline:Pari FAQ], which I've added to our spkg-install for readline when we're on a Mac.

So there are really two things I've changed:

* Add the fix for building readline (this involves changing `dynamic` to
`dynamiclib` in the generated Makefile)
* Change `-o` to `-a` in `spkg-install`: this is why we weren't noticing that
readline failed to build.

Of course, I don't know why it was `-o` instead of `-a` in the first place: if there was a good reason for that, someone should let me know and I'll change it back in the non-Mac case.

Reported by: craigcitro

Component: packages

CC:

Report Upstream:

Authors: ?

Dependencies:

Work issues:

Reviewers:

Merged in:

Attachments: