jugglinmike/4dam — pull request #1 by abgoldstein (2013-03-29 00:18:25+00:00)
Title: Finishing 4dam

Hey Mike,

I had a little bit of time in between things today so I thought I would wrap up this exercise from earlier.

Not a problem if you don't have time, but I actually had two questions coming out of this. One is checking to see whether or not there was a mistake in one of the iterator tests. On line 22, you were expecting this in context of the iteration to match the element we're looking at. Am I mistaken in thinking that this would be set to window since we're creating the closure from iteration.js? To fill my forEach function, I just borrowed Array.prototype.forEach, so if you make the change to the tests that you see in one of my commits here, then everything passes successfully. I rewrote the method from scratch as well but it seemed like this was a bug in the test. Let me know what you think if you have a chance.

I also was curious to see how to solve the extra credit. Wrapping up the other tests was quick, but making an object that is exactly equal to another but is an instance of another object is not something I've done before. I would really like to know what you guys had in mind.

Other than that, thanks again for meeting with me today. I really enjoyed getting a chance to talk with you, Ben, and the rest of the team.

Thanks!
Adam