Ettercap/ettercap — pull request #140 by jacob-baines (2013-03-22 00:32:27+00:00)
Title: More Compiler Warning Fixes

My last big commit I overlooked a warning which flagged some undefined behavior. My excuse (although not a good one) was that I didn't see the warning I generated. The warning was hidden in a cluster of others coming from ec_http (mostly due to ec_dissect.h, but I'll get there). As such, I decided I'd just go and clean it all up.

Most of the warnings were redundant declarations (prototypes in both the .h and the top of the .c). There were some interesting void* used in pointer arithmatic but I don't think those had any negative effects. From the 32 bit point of view the most annoying warnings were from an upcast of ptr* to uint64_t (in ec_dissect.h). The 64 bit number is used for session lookups. However, in all cases the 64 bit "magic" seems to be a pointer so I swapped it to a void* to both show intent and be size consistent.

That is really about it. I also enabled some more warnings and they are always on now. I don't believe I broke anything (works great on Ubuntu/32bit), but I touched a whole lot of stuff so it might be smart to pull this after the release.