reality/depressionbot — pull request #317 by JohnMaguire2013 (2013-03-21 04:11:50+00:00)
Title: fixing user tracking bug where aliases are missing a character

A bug was introduced in reality/jsbot@92bc767b090d6bbb6691f7170c635fe366b4a8f7 that broke user aliases.

This bug is not visible in #oaosidl due to the jsbot submodule being outdated (greload does not run "git submodule update".) To view the bug, make sure jsbot is up-to-date and then do the following:

1. Connect as "NickA".
2. Change your nick to "NickB".
3. Run "~alias NickA".

You will notice that the alias listed is "ickB".

I do not fully comprehend why the most recent commit to jsbot does to change the value of the nick (I see that it removes instances of ~, but I do not know why this is significant, and have not delved deep enough into jsbot's core and IRC output to understand further.)

Furthermore, the most recent commit to jsbot was supposed to fix users with +q (~) not showing up as online in the Web UI. The commit did not fix this bug on my end. As such, the better solution may be to revert commit reality/jsbot@92bc767b090d6bbb6691f7170c635fe366b4a8f7 rather than patching the users module in depressionbot. There may be other places in depressionbot that also need to be patched.

I may look further into this issue soon.