ceph/ceph — pull request #103 by dalgaaf (2013-03-12 17:26:18+00:00)
Title: mon/Monitor.h: return string instead of 'char *' from get_state_name()

Return a string instead of 'char *' to avoid usage of std::string:c_str()
to return a 'char *' from get_state_name().

Returning result of c_str() from a function is dangerous since the
result gets (may) invalid after the related string object gets
destroyed or out of scope (which is the case with return). So you may
end up with garbage in this case.

Related warning from cppcheck:
[src/mon/Monitor.h:172]: (error) Dangerous usage of c_str(). The value
returned by c_str() is invalid after this call.

Signed-off-by: Danny Al-Gaaf