garrettux/knife-vagrant — pull request #15 by spheromak (2013-03-12 03:12:20+00:00)
Title: don't modifyvm --name

Was there a good reason for using modifyvm --name? It doesn't seem very wise to me to do it this way. You already have hostname config option without having to use modifyvm. Aslo the current behavior can cause problems if you build 2 vagrants in different dirs, but with same hostname. This is a totally valid setup in vagrant, but not with knife-vagrant forcing the --name.

I remove this config paramater from our integration build of knife-vagrant, and thought I try to start a discussion.