jiahuang/d3-timeline — pull request #7 by ryepdx (2013-03-11 03:21:58+00:00)
Title: Chart sets height automatically if none is specified

I wanted the containing SVG element to shrink to fit the actual content in my timeline. Since I'm using the timeline to display an arbitrary number of recurring events, I can't predict ahead of time how tall the timeline will be. So I thought it would make sense to have the height property automatically set itself to the height of the timeline's content after the timeline gets called. This allowed me to then set the SVG element's "height" attribute to the timeline's height after calling the timeline on it.

I wonder if it would make more sense to set the SVG element's height from the timeline, though, since it seems at present that setting "height" doesn't actually do anything to the timeline's height.