two-bit-fool/mocha — pull request #1 by two-bit-fool (2013-03-06 17:18:41+00:00)
Title: Leaky global regression

If a global variable is whitelisted, it will throw off the length check in `checkGlobals` (a speed optimization made in 747588f92d1113dd0afccf660c85a5e589681c31).

This pull requests includes two commits:
1) a test to show the undetected global leak bug
2) a hand-woven revert of 747588f92d1113dd0afccf660c85a5e589681c31

Perhaps there's another way to fix this while still checking the lengths of `globals` and `ok`, but it wasn't obvious to me, and the overhead of doing the full leak check seemed pretty small.

---------------

As always, thanks so much for making _the_ best javascript test framework.