joyent/node — pull request #4930 by isaacs (2013-03-06 02:07:10+00:00)
Title: Fix 4928

@tjfontaine noticed that a huge amount of nextTick recursion errors were showing up in pummel/test-regress-GH-892. Since the last refactor to the Writable logic, this was also causing a range error. (The warnings had previously been in Readable, but the refactor moved the warning to Writable.write, which triggered a console.error, which calls process.stderr.write, aka Socket.write, etc.)

The first commit adds `--throw-deprecation`. This flag was very helpful in tracking down the recursion warning. `--trace-deprecation` was not so helpful, since the recursive nature of the warning caused a range error and blew up the output. It's often good to stop on the first deprecation, print a stack, and quit.

The second commit adds `execArgv` to the arguments passed to the child proc in pummel/test-regress-GH-892.

The third fixes the actual bug.