project-imas/app-password — pull request #1 by jmoody (2013-03-04 23:22:33+00:00)
Title: Password and Password Tests targets crash out of the box and various warnings

hi all,

i am evaluating this software. i forked and found a couple of problems.

i don't have any experience with pull requests that include an update to a submodule, so i might have done that part wrong.

#### the 'Password' and 'Password Tests' targets crash out of the box

```
Terminating app due to uncaught exception 'NSInvalidArgumentException',
reason: '*** - [NSBundle initWithURL:]: nil URL argument'
```

```
+ (NSString *)localizedStringForKey:(NSString *)key {
static NSBundle *bundle = nil;
static dispatch_once_t token;
dispatch_once(&token, ^{
==> NSURL *URL = [[NSBundle mainBundle] URLForResource:@"IMSPassword"
withExtension:@"bundle"];
bundle = [NSBundle bundleWithURL:URL];
});
return [bundle localizedStringForKey:key value:nil table:nil];
}
```

*NOTE: the maintainers _might_ not experience this problem because they have included the Build Products directory in the Framework Search Path and it is possible to get your Xcode environment into a state where this framework exists (in the build products directory) and the targets will run. however, out of the box both these targets crash.*

###### FIX:

1. remove the Build Products directory from the Framework Search Path
2. add the IMSPassword.bundle to the Copy Bundle Resource build phase of the 'Password' and 'Password Tests' targets

#### Warning in KIF submodule
```
KIFTestStep.m:428:18: Class method '+_enterCharacter:'
not found (return type defaults to 'id')
```

this has been fixed in the KIF project:
https://github.com/square/KIF/issues/178
https://github.com/square/KIF/pull/179

###### FIX:

updated the submodule to the latest KIF (master)