ansible/ansible — pull request #2239 by marktheunissen (2013-02-28 20:01:01+00:00)
Title: Fix bug from copy-paste

I made this branch to fix logging of passwords in syslog, as mentioned in the previous pull request, but I found that this happens automatically:

```
Feb 28 19:54:52 ansible-dev ansible-.ansible_module_generated: Invoked with login_user=None login_host=localhost host=localhost login_unix_socket=None state=present user=mark login_password=NOT_LOGGING_PASSWORD password=NOT_LOGGING_PASSWORD priv=None
```

However, in testing this, I discovered a bug that was introduced by my last PR. I modified the function `load_mycnf()` in `mysql_db` and tested it, then copied the modified function to `mysql_user`, because hey... they're identical, right? Well, not really... turns out someone had modified the name of the internal variable that holds the password *in only one of the mysql modules*, thus, the assumption that the shared code is equal no longer held.

This is definitely the problem with not allowing modules to actually share code, and having duplicates copies of functions. Not really sure how to fix this, but if there is some Python magic that can be used we should consider it, because errors like this are bound to creep in.