rectifyer/script.trakt — pull request #52 by nate1280 (2013-02-26 15:45:36+00:00)
Title: Some fixes

A nice long list of fixes:

- Add 4 helper functions to get settings in different types.
- Change the way json is imported in utils, use if, instead of a try block
- Change retries variable in utilities to be read every traktJsonRequest, instead of on plugin load, this way a change in that setting doesn't need a plugin restart.
- Remove HTTPS setting, and associated language string, since all requests are HTTPS now.
- Fix from ratings merge, a change done in notification rewrite was lost, pausedTime variable added.
- Fix for when a file is played directly, it will ignore it.
- Fix rating dialog always showing up.
- Change variables to use setting helper methods, to get values each call, instead of at plugin load.
- Add some checking on data returned via xbmc json, instead of referencing dictionary values directly.
- Add some more debug output in rating.py
- Move exclusion checking to a helper function in utilities.
- Change exclusion checking to be done in traktPlayer class, onPlayBackStarted, instead of every startedWatching call in scrobbler.
- This way the scrobbler is never initiated for the playback.

I've done some quick testing to make sure most stuff behaves, and it seems to, of course, more testing will be required.