archrival/Subsonic-Android — pull request #1 by bkrodgers (2013-02-21 04:38:29+00:00)
Title: Notification fix, play/pause fix

I believe what's happening is that for whatever reason the download service gets restarted. When it does, it initializes the play state to paused. I actually have two fixes in the pull request I'm sending you...they're probably redundant. I hadn't finished testing with one vs the other, but with both it didn't pop up at all today. But it sounds like one of them removes behavior you intended...if you intend to have the notification pop up right away at launch. Personally I prefer it not to do so, but that's fine if you intended to do it that way. I believe the change in net.sourceforge.subsonic.androidapp.service.DownloadServiceLifecycleSupport.deserializeDownloadQueue() on its own would do the job if you want to preserve the functionality. The change in net.sourceforge.subsonic.androidapp.service.DownloadServiceImpl.doPlay(DownloadFile, int, boolean) should also do the job, but it means the notification does not pop up until something starts playing.

Also in this change is a fix for the play/pause functionality not working with remotes that send the play command instead of play/pause. And I added having the metadata for the remote controls send the artist as well (i realize you're adding it to the title). I was also trying to find a solution for the lock screen controls not working consistently (they often just stop showing up on my DNA), but I haven't figured that one out yet.