TrinityCore/TrinityCore — pull request #9182 by Krogonos (2013-02-09 17:19:50+00:00)
Title: Culling of Stratholme Miscellaneous Fixes and Improvements

This PR includes the following Fixes/Improvements to the family of CoS scripts:
A little 'clean-up'
The grain crate highlighter should be deleted in addition to the Suspicious crate being deleted
Moved an enum from a header to the only source file that used it (Law of Demeter!)
Improved Arthas' use of Holy Light (based on running the instance) several times
Prevent Arthas from spamming Devotion Aura
Fixed waves (Types of npcs and amount of npcs that were spawned was incorrect)
Fixed a bug with the entrance preventing players from also leaving through that portal (Thanks to Kinzcool for the data/help)
Renamed an enum for clarity
Changed a script name for clarity

Still To do:
-Add scripts for CHROMIE_START(26527) and CHROMIE_MIDDLE(27915).
These two NPCS should be the ones that pretty much control the starting of the instance. i.e., CHROMIE_START should be the one that turns on WORLDSTATE_SHOW_CRATES
and CHROMIE_MIDDLE should be spawning Arthas, Lady Jaina Proudmoore, Uther the Lightbringer and the three knights behind him.

-Find the spell that Arthas casts THREE times throughout the instance while RPing. Currently we're using a workaround that entails using a generic attack emote instead. (Sniff??)

-Complete Act I (the REAL Act I! I'm refering to the pre-event that starts before Arthas'
initial RP event with Uther and Jaina)
This includes: Adding SAI to all of the npcs in the inn that the players walk into after talking to Chromie
Adding Pathing for the select few npcs at the inn that do have it
Adding SAI to that effen dog that growls at players/