acanyon/RubyTuesdays-ConnectFour — pull request #5 by antislice (2013-02-09 21:04:52+00:00)
Title: added more json test cases, fixed some documentation, changed test to match docs

New test cases for check_for_winner: in_progress, tie, diagonal left (red), diagonal left (blue). (I didn't include the mixin method for doing a diagonal left, let me know if you want me to add that to the pull request)

The doc changes are pretty straightforward.

The test change is sort of an opinion thing though. The docs for check_for_winner and make_move both imply that check_for_winner does *not* set any fields on the game, and that make_move is responsible for saving the return of check_for_winner somewhere. But the test for check_for_winner implies that the method should change the value of game.status and not necessarily return anything. I think the docs version creates a cleaner interface so I changed the test to match. If you disagree I can change it back.