PerlDancer/Dancer — pull request #891 by olof (2013-02-08 21:59:49+00:00)
Title: Warnings generated by generated Makefile.PL

ExtUtils::MakeMaker often has versions of the following format: '6.30_02'. Doing numerical comparisons on strings like this, as done in the script/dancer generated Makefile.PL, yields a warning:

Argument "6.57_05" isn't numeric in numeric ge (>=) at Makefile.PL line 5.

(Debian Unstable currently has 6.57_05.)

As a nitpick, I also changed the minimum version of EUMM to 6.30_01, as the LICENSE field was introduced at that release. I'm sure this shouldn't affect anybody, but it made it easier for me to correlate the comparison with the EUMM changelog. (Was there a reason why 6.30_02 was chosen over 6.30_01?)

Also, I'm well aware that my solution is quite ugly. You'd probably have better ideas on how to solve it.

Regards,
/Olof