nathanmarz/storm-deploy — pull request #20 by petermelias (2013-01-30 09:04:38+00:00)
Title: Fixed two SEVERE bugs (build breakers in fact) in the storm build portion of deploy script

NOTE: The current version of storm-deploy is currently BROKEN by the bugs for which fixes this pull request contains.

To be clear, the current version of storm-deploy must not have been tested because the following two issues are currently on the master branch and should affect ANY environment:

1) The pallet code that executes the call to the build_release.sh script utilizes the (sh) function which obviously will not work because BASH is required to execute Storm's build_release script.

2) The (get-release) function does not properly build the BASH conditional which checks for the release version specified on the CLI and simply ignores it even if it is present, resulting in an automatic install attempt of whatever is on the master branch of the Storm repo. This is obviously bad news since the bleeding edge is usually not desired in production.

I have included fixes for both of these issues and thoroughly tested them from a completely scratch deployment. I urge this request to be merged in as quickly as possible since I cannot see the current version working under any circumstances.