jclouds/jclouds — pull request #1265 by richardcloudsoft (2013-01-30 00:35:52+00:00)
Title: Fix CloudStack URL signing for fields with [ chars

Commit 69a8304 caused the CloudStack QuerySigner to generate invalid
signatures where key names contained square brackets, such as in the
"iptonetworklist[N]" field to deployVirtualMachine. The commit changed
the whole query string being URL-encoded, whereas previously the field
values were encoded but the field names were not. The CloudStack API
guide says that values that should be encoded for signing but not field
names, and indeed the commit does cause signatures to be rejected.

This commit reverses the change to QuerySigner.createStringToSign() and
adds a unit test for this case.

Tests: unit, live (no regressions) and manual.

A pull request for master (1.6) will be forthcoming once I've un-blocked https://groups.google.com/d/topic/jclouds-dev/FNAdDZO9-YA/discussion. Until then if this could get into 1.5.6 it would be great :)