scala/scala — pull request #1989 by adriaanm (2013-01-28 06:42:57+00:00)
Title: SI-6968 Simple Tuple patterns aren't irrefutable

Reverts part of c82ecab. The parser can't assume that
a pattern `(a, b)` will match, as results of
`.isInstanceOf[Tuple2]` can't be statically known until
after the typer.

The reopens SI-1336, SI-5589 and SI-4574, in exchange for fixing
this regression SI-6968. Keeping all of those fixed will require
a better definition of irrefutability, and some acrobatics to
ensure safe passage to the ambiguous trees through typechecking.

this drops the more ambitious commit from #1945 and now LGTM /cc @retronym