nursix/eden — pull request #3 by ptressel (2013-01-26 23:42:25+00:00)
Title: JS lint cleanup for static/scripts/S3

Dominic --

This is the JS lint cleanup -- have you got time for it? The changes are all pedestrian and didn't seem to cause problems. The only things I couldn't check were climate (due to its significant setup -- Fran said check it later) and ocr review (don't have access to a scanner at the moment. Noticed a couple of issues (missing data for vulnerability and some page elements that are being rendered as None in req update, but this was present before the lint cleanup). Hoping to get the lint cleanup out of the way so I can go back to the widgets ;-). Wondering if I should post a note about JS style with a pointer to our JS page in the wiki, since a batch of new lint issues appeared when I merged before sending this pull request -- what do you think?

What's in this pull request:

1) Convert climate js file from UTF-16 (dead format, JS lint can't read it) to UTF-8. This is a separate commit so the actual lint diff is visible.
2) JS lint cleanup -- almost all missing ; or extra ; or repeat declarations in if branches or cases statements or for loop indices. There is a real issue, left for later, in vulnerability (redeclaration of two functions). I left a pair of empty { } in because they had explanatory comments in them.
3) Tweaks to vulnerability so the controller would run without ticketing, so I could test it.
4) Fran says s3.dataTables.new.js was an experiment that's not going to be used -- said it should probably be removed.

-- Pat