funtoo/funtoo-overlay — pull request #29 by Hoverbear (2013-01-23 21:06:39+00:00)
Title: Removed a buggy patch from Pyzy

LiaoTao reported having troubles building this. We managed to figure out that the patch is not necessary to have the package successfully compile.

I'd highly recommend taking a harder look at this, as I didn't get a chance to test this (in fact I have no idea what this package is even for.)

The Log from IRC:

[12:11pm] LiaoTao:
Hey, I'm having trouble with dev-libs/pyzy (req for app-i18n/ibus-pinyin-1.5.0) http://bpaste.net/show/72350/
[12:12pm] panda|x201 joined the chat room.
[12:17pm] Hoverbear:
LiaoTao: Look at line 2654
[12:17pm] Hoverbear:
264
[12:18pm] Hoverbear:
LiaoTao: Screw me…. Line 246
[12:18pm] Hoverbear:
LiaoTao: "ln: failed to create symbolic link ‘./pyzy-database-1.0.0.tar.bz2’: File exists" Is that the problem?
[12:18pm] LiaoTao:
Hoverbear, First error is at 178
[12:19pm] Hoverbear:
Bahaha
[12:19pm] Hoverbear:
LiaoTao: Two errors, one file
[12:20pm] shiin left the chat room. (Quit: Textual IRC Client: http://www.textualapp.com/)
[12:20pm] LiaoTao:
Hoverbear, I've tried looking in the ebuild, and it applies a patch to make it use an external pyzy-database-1.0.0.tar.bz2
[12:20pm] LiaoTao:
I figure the patch is somehow misconceived
[12:20pm] Hoverbear:
LiaoTao: Maybe
[12:20pm] Hoverbear:
LiaoTao: Try removing the patch?
[12:21pm] LiaoTao:
Hoverbear, Sure, just give me a minute or two
[12:23pm] tuxtor left the chat room. (Ping timeout: 244 seconds)
[12:23pm] LiaoTao:
Hoverbear, Oh damn, hold on. I was using an already edited ebuild when pasting that error message. Retrying default and pasting original error first.
[12:23pm] Hoverbear:
Hahaha
[12:24pm] LiaoTao:
Hoverbear, Nevermind, the edit was irrelevant.
[12:25pm] Hoverbear:
LiaoTao: :)
[12:26pm] HedgeMage:
biberao: go for it, but I'll be slow to respond
[12:27pm] LiaoTao:
Hoverbear, Yeah, it works. The patch seems to be for making the ebuild handle the download instead of the build script.
[12:27pm] Hoverbear:
LiaoTao: Hrm. But it can't find the file? (Then later tries to link the file only to find it not there?)
[12:27pm] Hoverbear:
Find it is there***
[12:27pm] anathaema left the chat room. (Ping timeout: 255 seconds)
[12:27pm] dangergrrl joined the chat room.
[12:28pm] LiaoTao:
Hoverbear, Either the patch is not correct or the ebuild is missing some code to place the externally downloaded file in the right folder.
[12:28pm] LiaoTao:
I'm just not sure which folder is correct.
[12:29pm] Hoverbear:
LiaoTao: Yeah, hrm.
[12:29pm] LiaoTao:
Here's the offending patch anyway: http://bpaste.net/show/72353/
[12:30pm] Hoverbear:
LiaoTao: Looks like somewhere in /var/tmp/portage/dev-libs/pyzy-0.1.0/work/pyzy-0.1.0/data/db/open-phrase ?
[12:30pm] LiaoTao:
Hoverbear, except that folder doesn't exist before actually starting the build, it seems.
[12:30pm] LiaoTao:
I suppose I could rewrite the build to create it before placing the file there.
[12:30pm] Hoverbear:
Hrm
[12:31pm] Hoverbear:
LiaoTao: Have you compared it to both of these? http://gpo.zugaina.org/dev-libs/pyzy
[12:32pm] Hoverbear:
Looks like chromiumOS overlay has a build as well
[12:33pm] LiaoTao:
I'll try it with that build, thanks
[12:33pm] Hoverbear:
They're probably the same
[12:33pm] Hoverbear:
But I didn't really look
[12:34pm] LiaoTao:
The chrome one has "mv ../db ./data/db/open-phrase/ || die" in src_prepare
[12:34pm] LiaoTao:
Probably fixes it
[12:36pm] Hoverbear:
LiaoTao: If it does can you submit a patch to the funtoo overlay?
[12:37pm] LiaoTao:
Hoverbear, I could, but it didn't.
[12:37pm] Hoverbear:
Goddamnit
[12:37pm] LiaoTao:
I'm not sure what "../db" is supposed to be
[12:37pm] LiaoTao:
It dies there
[12:37pm] Hoverbear:
LiaoTao: Are you copying the entire ebuild?
[12:38pm] LiaoTao:
Hoverbear, Heh, everything except their distribution package. Retrying with the whole ebuild then.
[12:38pm] Hoverbear:
LiaoTao: Might as well
[12:39pm] Hoverbear:
LiaoTao: I'm firing up my fntoo shell
[12:41pm] LiaoTao:
Hoverbear, Same error. So unless their patch is different...
[12:41pm] Hoverbear:
LiaoTao: Yeah I don't even have that build, let me re-sync
[12:42pm] LiaoTao:
Hoverbear, There's a bug in the funtoo tracker concerning a checksum error earlier this week, when it was added.
[12:43pm] LiaoTao:
The submitter seemed to get it built all right when the checksum was fixed. Sigh
[12:43pm] Hoverbear:
LiaoTao: Yeah.
[12:44pm] init_6 joined the chat room.
[12:45pm] Hoverbear:
LiaoTao: I got a different error
[12:45pm] LiaoTao:
Hoverbear, The plot thickens...
[12:46pm] Hoverbear:
LiaoTao: http://fpaste.org/d8fb/
[12:46pm] Hoverbear:
LiaoTao: Line 177
[12:46pm] LiaoTao:
Looks sort of the same, no?
[12:47pm] Hoverbear:
Sort of yeah
[12:47pm] Hoverbear:
Mine is looking for a different file though
[12:47pm] Hoverbear:
wtf
[12:47pm] LiaoTao:
Hoverbear, It's probably supposed to be in the archive which fails to be found at 173, same as mine.
[12:47pm] Hoverbear:
Ah yeah you're right
[12:49pm] Hoverbear:
LiaoTao: You can edit the build and have it log some directory listings to a log file and take a look
[12:50pm] LiaoTao:
Hoverbear, I'm not sure I follow you, sorry.
[12:51pm] Hoverbear:
LiaoTao: Don't mind me, I'm crazy
[12:51pm] SS3 left the chat room. (Quit: "")
[12:52pm] Hoverbear:
LiaoTao: I don't see where it's getting the new dictionary file from
[12:52pm] Hoverbear:
LiaoTao: It's getting rid of a wget and adding a link, but I don't see what it's linking too
[12:53pm] LiaoTao:
Hoverbear, I figure it should link to wherever the ebuild puts the DB...
[12:54pm] LiaoTao:
(It's in the SRC URI)
[12:54pm] Hoverbear:
LiaoTao: Yeah. But where does "DBTAR" come from?
[12:55pm] LiaoTao:
I'll skim through the makefile
[12:56pm] Hoverbear:
LiaoTao: I removed the patch and it built successfully
[12:57pm] Hoverbear:
Trying again to make sure
[12:57pm] LiaoTao:
Hoverbear, Yeah, but doesn't the author have a good reason to patch out the download?
[12:58pm] Hoverbear:
Maybe, doesn't matter if it doesn't work though
[12:58pm] LiaoTao:
Ah: DBTAR = pyzy-database-$(DBVER).tar.bz2
[12:58pm] LiaoTao:
So the name of the DB file
[12:58pm] wolkengucker joined the chat room.
[12:58pm] Hoverbear:
Maybe that's not getting transfered
[12:59pm] Hoverbear:
LiaoTao: Either way, this http://fpaste.org/kNiU/ works
[1:00pm] LiaoTao:
Hoverbear, Yeah, and you can remove the second line from SRC_URI. I'm just trying to make the patch work.
[1:01pm] bubu^ joined the chat room.
[1:01pm] LiaoTao:
Also, "pyzy-${PV}.tar.gz" could be "${P}.tar.gz", and src_unpack should work without being defined.
[1:01pm] LiaoTao:
AFAIK
[1:02pm] Hoverbear:
LiaoTao: I'm going to submit a pull request removing the patch
[1:02pm] LiaoTao:
Hoverbear, All right.