danielreuther/liferay-portal — pull request #12 by matethurzo (2013-01-09 15:22:10+00:00)
Title: Pull request 311 lps 28494

Daniel, here are my changes for the test PR.

There was a problem with the import of the ExecutionTestListener, I've added the correct one.

In the setUp method I've noticed that the screen name generator is being created by the ScreenNameGeneratorFactory which by function is an abstract factory, meaning that it will create a certain implementation of a screen name generator, but we are unaware of the implementation. Because the test is called DefaultScreenNameGeneratorTest I changed the creation of the class because we are explicitly testing the DefaultScreenNameGeneratorTest. A change in the factory or changing the property in the portal.properties would break the test, even if then DefaultScreenNameGenerator is untouched.

Following this logic the testVerifyScreenNameGeneratorClass method is unnecessary.

Can you please check the changes and run the test if it completes for you normally? Also please check different property configurations like changing the default user name and stuff. I'm closing the other PR if this seem to work for you just let me know and I'll forward it.

Thanks,

Máté