troessner/reek — pull request #124 by EmilRehnberg (2013-01-09 23:42:11+00:00)
Title: Pass tests for spec/gem

I am an Ubuntu 12.10 user and the tests in "spec/gem" are not passing. The "Manifest.txt" needs an update (for the first 2 tests) and I needed to add the "yard" gem (for the third test).

$ git clone https://github.com/troessner/reek.git
$ cd reek
$ git log
commit 8da5785c3cdf4353c4fc11c0b6cf6fe6b3874491 ...
$ rspec spec/
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}
FFF.........................................................................................................................................................................................................................................................................................................................................*..............................................................................................................................................................................................................................................................................................................................................................

Pending:
Reek::Smells::FeatureEnvy when reporting yaml reports the referring lines
# No reason given
# ./spec/reek/smells/feature_envy_spec.rb:213

Failures:

1) gem manifest lists every current file
Failure/Error: (@current_files - @manifest).should == []
expected: []
got: [".rspec", ".rvmrc", ".travis.yml", "CHANGELOG", "Gemfile", "Gemfile.lock", "config/cucumber.yml", "lib/reek/core/hash_extensions.rb", "lib/reek/core/smell_repository.rb", "lib/reek/source/source_repository.rb", "lib/reek/version.rb", "spec/reek/source/sexp_formatter_spec.rb"] (using ==)
# ./spec/gem/manifest_spec.rb:17

2) gem manifest lists no extra files
Failure/Error: (@manifest - @current_files).should == []
expected: []
got: ["History.txt"] (using ==)
# ./spec/gem/manifest_spec.rb:20

3) yardoc raises no warnings
Failure/Error: @stderr.should == ''
expected: ""
got: "sh: 1: yardoc: not found\n" (using ==)
Diff:
@@ -1 +1,2 @@
+sh: 1: yardoc: not found

# ./spec/gem/yard_spec.rb:12

Finished in 2.36 seconds
683 examples, 3 failures, 1 pending

Failed examples:

rspec ./spec/gem/manifest_spec.rb:16 # gem manifest lists every current file
rspec ./spec/gem/manifest_spec.rb:19 # gem manifest lists no extra files
rspec ./spec/gem/yard_spec.rb:11 # yardoc raises no warnings