NigelCunningham/pam-MySQL — pull request #6 by nickramser (2013-01-04 20:06:04+00:00)
Title: Fixed a bug that caused the length of the drupal7 salt to be reported incorrectly and fail

strncpy does not null-terminate the destination if it truncates the source string. strlen requires a null character to properly report the length. See the following for explanation and examples: http://stackoverflow.com/questions/1176737/strncpy-and-using-sizeof-to-copy-maximum-characters

I Increased the size of salt and added a null char at the end so that strlen() returns the proper length of the salt.

I am not sure how/why this ever worked on your system? Only possible explanation I have would be a different compiler or architecture (I'm using RHEL6 x86_64) or you got lucky during testing and had a null char in memory following the char salt[8].

Thanks!