phingofficial/phing — pull request #179 by llaville (2013-01-04 15:11:04+00:00)
Title: ForeachTask enhancement

Hello Michiel,

Recently, I've worked with phing a lot and found some bugs, typo error and probably some enhancement.

Here is the first one I suggest now !

Whatever you use fileset or list attribute, you got always the same log message

Processed X directories and Y files

where X and Y may varied depending of context.
But when you use the list attribute, this message as non sense.

So here is my patch with unit test suite (that is still missing on foreach task system).

Here is my results on 3 platforms :

PHP 5.2.17

PHPUnit 3.6.12 by Sebastian Bergmann.

......

Time: 4 seconds, Memory: 18.75Mb

OK (6 tests, 6 assertions)

PHP 5.3.20

PHPUnit 3.7.10 by Sebastian Bergmann.

......

Time: 2 seconds, Memory: 18.25Mb

OK (6 tests, 6 assertions)

PHP 5.4.10

PHPUnit 3.7.10 by Sebastian Bergmann.

......

Time: 1 second, Memory: 11.00Mb

OK (6 tests, 6 assertions)

Enjoy !
- Laurent