foursquare/rogue — pull request #71 by ktoso (2012-12-25 19:05:39+00:00)
Title: Resolves #69 - in which or(where, whereOpt(None)) creates a bad query

Hello again,
It's been some time since I found #69, but since it's now Christmas :christmas_tree: I found some time and came back to this and fixed the issue. :-)

Reminding the problem again:

```
// what was the problem:
Venue.where(_.or(_.where(_.email eqs " "), _.where(None)(_.neverMind eqs _)))

// we'd get:
{"$or": [{"email": " "}, { } ]}
^ false ^ always true => we fetch the entire collection
```

There are tests for both cases attached (Some/None) and a fix.

I have added a method to `AndCondition`, if that's something you'd rather want to keep without methods please let me know where I should move this `isEmpty` method (or don't do it as a method?).

Thanks again for the great library,
Looking forward to the 2.0 / 2.10 releases!

--
Konrad Malawski