juliocamarero/liferay-portal — pull request #957 by laszlocsontos (2012-12-19 08:26:35+00:00)
Title: [TECHNICAL SUPPORT] LPS-31259

Hi Julio,

* With all the refactorizations (which are very nice, by the way) it is really hard to see where is the actual bug fixing. Could you please send a first commit with just all the refactorizations and then a second commit with the actual fix?

I broke my previous commits into smaller ones in order to ease reviewing.

* Also, in the test, I saw you wrote a completely new method. However, the existing method has almost the same logic... are you sure your logic can not be just added to the existing one?

Yes, indeed; I re-factored the common part into method prepareLayoutSetPrototype(...).

* Final thoughts

If you run the integration test, the following two methods will fail:

- testLSPLinkEnabledwithPageDeletion
- testLSPLinkEnabledwithPageDeletionFromLP

After some investigation, it turned out that the error persists as of commit "bdcacba06a186bc7dfa31d61cb7619a8e82ea579". I talked to @matethurzo about it and he said he was going to fix it.

Thanks,
Laszlo