zinnschlag/openmw — pull request #467 by Thoronador (2012-12-17 22:18:37+00:00)
Title: Remove 'GMST fixing' for dirty GMST records

Resolves issue 401: https://bugs.openmw.org/issues/401

The 'fixing' for so-called dirty GMSTs does not work properly in its
current state anyway, so it should be removed. Fixing the 'GMST fixing'
might not be possible, because whether or not a GMST is 'dirty' depends
on the language version of MW. Therefore different 'fixing' algorithms
would be required for the different MW localisations, and I do not see
a good reason why GMST values should be hard-coded in the GMST load
procedure. In my opinion, it only clutters the code.

Last but not least, I believe that it is not the task of the engine to
clean ESM files from dirty entries. That is a job for the modders, who
should only release clean ESM/ESP files in the first place. There are
even tools to do the cleaning, not only for GMSTs but for any record
type. The engine should not need to worry about whether a file is
'dirty' or not.

That is why I believe a feature for cleaning ESM/ESP files shall not be
part of the engine.