xbmc/xbmc — pull request #1951 by jmarshallnz (2012-12-18 06:00:39+00:00)
Title: use a smart ptr for the BaseSettingControl pointers

So that they stay alive after window close if they're still being used. fixes #13766.

Pressing Ctrl-M while awaiting a setting change in a dialog (e.g. while choosing skin) allows you to switch to Music underneath the dialog, thus freeing the settings vector. When the dialog window is then closed, it attempts to use the free'd setting.

This fixes it in the obvious way by making them smart pointers.