libgit2/libgit2 — pull request #1151 by arrbee (2012-12-17 19:08:03+00:00)
Title: Fix diff constructor names

The ObjectiveGit folks point out that the constructor functions for diffs are confusingly named. For example, `git_diff_workdir_to_index` actually makes the index be the "old" side of the diff and the workdir be the "new" side of the diff. This is in contrast to `git_diff_tree_to_tree` that takes the "old" side as the first tree parameter and the "new" side as the second tree parameter.

This PR changes the names of three of the confusing diff APIs to be consistent with the expected output. Namely:

* `git_diff_index_to_tree` becomes `git_diff_tree_to_index`
* `git_diff_workdir_to_index` becomes `git_diff_index_to_workdir`
* `git_diff_workdir_to_tree` becomes `git_diff_tree_to_workdir`

Obviously this breaks bindings, but it seems like a good fix to get in pre v1.0.