kayahr/console-shim — pull request #5 by dmp42 (2012-12-16 20:54:44+00:00)
Title: Pullme

Hi there.

First changes are pretty harmless:
- a number of entirely cosmetic fixes (extra spaces, consistent quoting style, missing semicolon)
- trivial fixes (comparison to undefined, and simplify test in for)
- upgrade log4js to latest version

Second (more important) change is about the use of conditional compilation. Unfortunately closure will remove the /*cc*/ as with any other comment - hence the minified version is broken on IE... Thus I replaced it with an eval (in order to workaround closure) - dirty, but there really is no good solution IIRC.
This is: https://github.com/jsBoot/console-shim/commit/b5d51864e9c302b0cc350e7cd294be5cfc5f453b

Third, I upgraded closure to the latest version - which in turn required type hinting adjustements to avoid warnings (closure really is damn pedant...).
This is:
https://github.com/jsBoot/console-shim/commit/57f9d0eaf081cec39f66bcb7a3e5d54eeb37e553
and
https://github.com/jsBoot/console-shim/commit/9f353a0bf17165df74ad1c69720928ffb0e613be

... this allowed for ES5_STRICT minification, which I added to the build file:
https://github.com/jsBoot/console-shim/commit/472deeeedfef9ad20cfb09d24c7b8931a57d6ba9

Finally, I commited a .jshintrc file for good measure.

Feel free to cherry pick what you deem appropriate, or ask to amend this pull request if you think something is bad.

Cheers.