plaa/openrocket — pull request #16 by soupwizard (2012-12-16 08:55:25+00:00)
Title: fixed ~180 build warnings

Big commit to reduce build warnings from 232 down to 44 warnings. By fixing the simple ones, the rest of the devs will be able to see more important warnings and fix them.

List of fixes:

- Fixed 'references to generic type needs parameterized' warnings. There are still some left that I don't know enough about the code to fix.

- Fixed 'variable Foo is hiding variable Bar' warnings by renaming lower scoped variables.

- Removed unused imports that were causing build warnings.

- added @suppress 'unused methods' for some methods

- added @suppress 'unused variables' for some variables; there were 1 or 2 variables that were clearly unused and unneeded, those were removed.

- added @suppress to 2 warnings about resource leaks in a file open; it was clear the files were actually closed in the same method. There are some resource leak warnings left that should be looked at.

- Fixed one deprecated method warning in ColorChooser.java for a java lib method by changing to use the newer replacement method.